Submission Details
Severity:
Unstake can lead to loss of NFT
Summary
Streets.unstake() uses transferFrom which can lead to asset loss if the target address cannot receive ERC721.
Vulnerability Details
oneShotContract.transferFrom(address(this), msg.sender, tokenId);
Streets.unstake() uses transferFrom and does not check if the target address can receive ERC721. If it is such an address, then the asset is lost.
Impact
High - asset loss
Tools Used
Manual code inspection.
Recommendations
Use ERC721.safeTransferFrom()
Rewards breakdown
nSLOC
201This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.