Submission Details
Severity:
Event `Battle` emits wrong winner
Summary
Event Battle emits wrong winner
Vulnerability Details
There is = missing in the comparison in Battle event. This leads emission of wrong winner in a case where random number is equal to defenderRapperSkill. As in this case, winner emitted by event is challenger.
Impact
Wrong winner is emitted when random number is equal to defenderRapperSkill.
Tools Used
Manual Review
Recommendations
- emit Battle(msg.sender, _tokenId, random < defenderRapperSkill ? _defender : msg.sender);
+ emit Battle(msg.sender, _tokenId, random <= defenderRapperSkill ? _defender : msg.sender);
Updates
Lead Judging Commences
inallhonesty almost 2 years ago
Submission Judgement Published Assigned finding tags:
Contradictory battle result event
Rewards breakdown
nSLOC
201This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.