Submission Details
Severity:
There is a mismatch between the stated base skill value of rapers in the documentation and it's actual definition in the code.
Vulnerability Details
In protocol's documentation it's mentioned that, "A base skill of 50 is applied to all rappers in battle.". However in RapBattle contract, the variable representing the rapers BASE_SKILL is defined as 65.
uint256 public constant BASE_SKILL = 65; // The starting base skill of a rapper
Impact
The mismatch can cause a confusion to the users of the project.
Tools Used
Manual Review
Recommendations
Assign the value as stated in the documentation:
- uint256 public constant BASE_SKILL = 65; // The starting base skill of a rapper
+ uint256 public constant BASE_SKILL = 50; // The starting base skill of a rapper
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Battle skill is 65 not 50
Rewards breakdown
nSLOC
201This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.