Submission Details
Severity:
In `RapBattle` wrong condition used in `RapBattle::emit Battle()` while emitting the event `<` is used instead of `<=`. Leading to wrong data emitted
Summary
In RapBattle::emit Battle wrong condition is used to check for winner. it uses if less than < which does not include if random is equal to defenderRapperSkills. This does not correspond with the later logic which include less than or equal. cause lets say when random and defenderRapperSkills are equal the winner emitted by the event will be the challenger instead of defender. whereas the logic while transfering the prize will be the _defender .
Impact
Event emission is incorrect, leading to off-chain functions potentially malfunctioning.
Recommendations
emit Battle(msg.sender, tokenId,
- random < defenderRapperSkill ? _defender : msg.sender);
+ random <= defenderRapperSkill ? _defender : msg.sender);
// the logic here incapulates both less than or equal to unlike the event
if (random <= defenderRapperSkill) {
credToken.transferFrom(msg.sender, _defender, _credBet);
} else {
credToken.transfer(msg.sender, _credBet);
}
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
Contradictory battle result event
Rewards breakdown
nSLOC
201This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.