First Flight #12: Kitty Connect

First Flight #12: Kitty Connect
Beginner FriendlyFoundryNFTGameFi
100 EXP
View results
Submission Details
Severity: low
Invalid

Magic numbers usage for "gasLimit" storage variable inside the constructor of KittyBridge.sol

Summary

Magic numbers for "gasLimit" storage variable inside the constructor of "KittyBridge.sol"

Vulnerability Details

As we know magic numbers are hardly against best practices, so usage of constants is highly encouraged, this way we will have
a constant as one source of a truth for every usage of the variable and also will save gas for the protocol since constants in Solidity are typed in the bytecode directly and do not get stored in the storage.

Impact

Low, since it's gas related issue and would be a big impact for example, if an extra zero is being added to the variable.

Tools Used

Slither

Recommendations

Use constant such as:
uint256 internal constant GAS_LIMIT = 400000;

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
hashov Submitter
about 1 year ago

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.