Submission Details
Severity:
Ownership info of bridged NFTs is not updated correctly
Summary
After a NFT is bridged KittyConnect on the destination chain will mint the NFT to the specified owner but the function doesn't add the new token to the s_ownerToCatsTokenId array. Users querying the number of the tokens they own will get an incorrect accounting.
Tools Used
Manual review
Recommendations
After minting the NFT add the token id to the s_ownerToCatsTokenId array.
function mintBridgedNFT(bytes memory data) external onlyKittyBridge {
// rest of the function
uint256 tokenId = kittyTokenCounter;
kittyTokenCounter++;
+ s_ownerToCatsTokenId[catOwner].push(tokenId);
// rest of the function
}
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
owner's token ID array not updated in `mintBridgedNFT`
Rewards breakdown
nSLOC
235This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.