Submission Details
Severity:
No indexed parameters in events in KittyConnect
Summary
None of the events in KittyConnect has indexed parameters.
Vulnerability Details
Indexed parameters are used to track the relevant information in events. KittyConnect has 6 events and none of them has indexed parameters. Event TokensRedeemedForVetVisit is never used so it can be removed.
Impact
Low impact, it makes the events less useful than what they could be.
Tools Used
Manual review
Recommendations
Turning 'indexed' the relevant parameters in the mentioned events:
contract KittyConnect is ERC721 {
.
.
.
- event ShopPartnerAdded(address partner);
+ event ShopPartnerAdded(address indexed partner);
- event CatMinted(uint256 tokenId, string catIpfsHash);
+ event CatMinted(uint256 indexed tokenId, string catIpfsHash);
- event TokensRedeemedForVetVisit(uint256 tokenId, uint256 amount, string remarks);
- event CatTransferredToNewOwner(address prevOwner, address newOwner, uint256 tokenId);
+ event CatTransferredToNewOwner(address prevOwner, address newOwner, uint256 indexed tokenId);
- event NFTBridgeRequestSent(uint256 sourceChainId, uint64 destChainSelector, address destBridge, uint256 tokenId);
+ event NFTBridgeRequestSent(uint256 indexed sourceChainId, uint64 indexed destChainSelector, address destBridge, uint256 indexed tokenId);
- event NFTBridged(uint256 chainId, uint256 tokenId);
+ event NFTBridged(uint256 indexed chainId, uint256 indexed tokenId);
Rewards breakdown
nSLOC
235This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.