First Flight #12: Kitty Connect
First Flight #12: Kitty Connect
Beginner FriendlyFoundryNFTGameFi
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

Gas/Low level findings

feder

Summary

KittyBridgeBase::KittyBridge__NothingToWithdraw and KittyBridgeBase::KittyBridge__FailedToWithdrawEth errors are not being used in the protocol and can be removed from the code to save on gas.

Vulnerability Details

Impact

Extra gas consumption.

Tools Used

Manual review.

Recommended Mitigation

- error KittyBridge__NothingToWithdraw();
- error KittyBridge__FailedToWithdrawEth(address owner, address target, uint256 value);

//================================//

Summary

The KittyBridgeBase::onlyKittyConnect modifier is not being used in the protocol and can be removed from the code to save on gas.

Vulnerability Details

Impact

Extra gas consumption.

Tools Used

Manual review.

Recommended Mitigation

- modifier onlyKittyConnect() {
- if (msg.sender != kittyConnect) {
- revert KittyBridge__NotKittyConnect();
- }
- _;
- }

//================================//

Summary

The KittyConnect::TokensRedeemedForVetVisit event is not being used in the protocol and can be removed from the code to save on gas.

Vulnerability Details

Impact

Extra gas consumption.

Tools Used

Manual review.

Recommended Mitigation

- event TokensRedeemedForVetVisit(uint256 tokenId, uint256 amount, string remarks);
Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!