Submission Details
Severity:
Reading from storage in `KittyConnect::constructor` every iteration in the for-loop, which is gas inefficient.
Vulnerability Details
In KittyConnect::constructor, the function reads from storage in every iteration of the for-loop. Reading from storage is more expensive than reading from memory.
Impact
Leads to spending more gas than necessary.
Tools Used
Manual Review
Recommendations
Consider storing the length of the array in a local variable and using it in the for-loop. This will reduce the gas cost of the function.
constructor(
address[] memory initShops,
address router,
address link
) ERC721("KittyConnect", "KC") {
+ uint256 initialShopsArray = initShops.length;
+ for (uint256 i = 0; i < initialShopsArray; i++) {
- for (uint256 i = 0; i < initShops.length; i++) {
s_kittyShops.push(initShops[i]);
s_isKittyShop[initShops[i]] = true;
}
i_kittyConnectOwner = msg.sender;
i_kittyBridge = new KittyBridge(router, link, msg.sender);
}
Rewards breakdown
nSLOC
235This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.