First Flight #12: Kitty Connect

First Flight #12: Kitty Connect
Beginner FriendlyFoundryNFTGameFi
100 EXP
View results
Submission Details
Severity: low
Invalid

## kittyConnect::bridgeNftToAnotherChain failed to use the return value from i_kittyBridge.bridgeNftWithData

Summary

kittyConnect::bridgeNftToAnotherChain made an external call to bridgeNftWithData in the kittyBridge contract, but it fails to use the value returned by the external call

Vulnerability Details

.
.
.
if (idx < (userTokenIds.length - 1)) {
s_ownerToCatsTokenId[msg.sender][idx] = lastItem;
}
emit NFTBridgeRequestSent(block.chainid, destChainSelector, destChainBridge, tokenId);
// @audit failed to use the return value
i_kittyBridge.bridgeNftWithData(destChainSelector, destChainBridge, data);
}

Impact

Low, as it doesn't pose a threat to the user or contract. The return value is just a data.

Tools Used

Manual review/ slither

Recommendations

Ensure that all the return values of the function calls are used.

Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.