Submission Details
Severity:
Rarity of tokens is not respected due to random_words[0] % 3
Rarity of tokens is not respected due to random_words[0] % 3
All types are equally rare in the given implementation because of the lines shown here.
rarity: uint256 = random_words[0] % 3
self.tokenIdToRarity[ERC721._total_supply()] = rarity
The desired behavior is to make rarity weighted as follows :-
x: uint256 = random_words[0] % 100
rarity: uint256 = 0
if x >= 95:
rarity = LEGEND
elif x >= 70:
rarity = RARE
else:
rarity = COMMON
self.tokenIdToRarity[ERC721._total_supply()] = rarity
Tools
Manual
Updates
Lead Judging Commences
inallhonesty
over 1 year ago
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
Rarity is 1/3 instead of what the docs say
Rewards breakdown
nSLOC
136This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.