Submission Details
Severity:
Participant are not deleted from the producers array after the event is finished in `MartenitsaEvent`
Summary
Details
We add participants in the MartenitsaEvent in the producers array via this function:
function _addProducer(address _producer) internal {
isProducer[_producer] = true;
producers.push(_producer);
}
However when the event is stopped, the participants are not removed from the array:
function stopEvent() external onlyOwner {
require(block.timestamp >= eventEndTime, "Event is not ended");
for (uint256 i = 0; i < participants.length; i++) {
isProducer[participants[i]] = false;
}
}
Impact
When calling MartenitsaToken::getAllProducers will return wrong information.
function getAllProducers() external view returns (address[] memory) {
return producers;
}
Tools Used
Manual Review
Recommendations
Don't add the event participant in the array.
function _addProducer(address _producer) internal {
isProducer[_producer] = true;
-producers.push(_producer);
}
Updates
Lead Judging Commences
bube over 1 year ago
Submission Judgement Published Assigned finding tags:
Producers array not updated
Rewards breakdown
nSLOC
239This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.