Submission Details
Severity:
Possible failure to initialize in `HealthToken.sol`
Summary
Initializing addresses in a different function might lead to Initialization failure
Vulnerability Details
Instead of utilizing the setMarketAndVotingAddress() function within the HealthToken.sol contract to set the addresses of the MartenitsaMarketplace and MartenitsaVoting contracts, it is preferable to initialize them within the constructor to mitigate the risk of initialization failure.
Impact
Impact : Low
Likelihood : Low
Tools Used
Manual Review
Recommendations
constructor() ERC20("HealthToken", "HT") Ownable(msg.sender) {
+ _martenitsaMarketplace = MartenitsaMarketplace(martenitsaMarketplace);
+ _martenitsaVoting = MartenitsaVoting(martenitsaVoting);
}
- function setMarketAndVotingAddress(address martenitsaMarketplace, address martenitsaVoting) public onlyOwner {
- _martenitsaMarketplace = MartenitsaMarketplace(martenitsaMarketplace);
- _martenitsaVoting = MartenitsaVoting(martenitsaVoting);
- }
Rewards breakdown
nSLOC
239This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.