Submission Details
Severity:
Wrong HealthToken logic for minting
Summary
More than allowed Health Tokens can be minted due to incorrect Logic
Vulnerability Details
In MartenitsaMarketplace.sol::collectReward(), there is incorrect logic in the line
_collectedRewards[msg.sender] = amountRewards;
This line is incorrect as the amountRewards should be added to the _collectedRewards[msg.sender] array in order for Health Token minting calculation to work properly. This flaw in logic can be exploited to mint more Health Tokens than deserved.
Impact
Funds in the form of HealthTokens can be stolen/minted.
Tools Used
Manual Review
Recommendations
Change the line to
_collectedRewards[msg.sender] += amountRewards;
Rewards breakdown
nSLOC
239This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.