Beginner FriendlyFoundryGameFi
100 EXP
View results
Submission Details
Severity: high
Valid

Users sending extra amount as appreciation to the seller via `MartenitsaMarketplace::buyMartenitsa` function, leads to extra amount being stuck in `MartenitsaMarketplace` contract.

Summary

The user s sending extra eth amount while buying the producer's martenitsa token, will make that extra eth amount sent getting stuck in the MartenitsaMarketplace contract and it cannot be recovered back.

Vulnerability Details

The vulnerability is present in the MartenitsaMarketplace::buyMartenitsa function where it accumulates the extra eth amount being sent in the contract itself and there is no way to recover it.

Impact

The user sending extra eth amount to the producer as a token of appreciation, will make the extra eth amount getting stuck in MartenitsaMarketplace contract and is not actually sent to the producer.

Tools Used

Manual Review

Recommendations

Transfer the whole msg.value to the seller.

Updates

Lead Judging Commences

bube Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Excess ETH not refunded to the user

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.