Submission Details
Severity:
Improper revert results in misleading the user
Summary
Improper revert results in misleading the user
Vulnerability Details
In MartenitsaMarketplace::collectReward function, if the (count / requiredMartenitsaTokens) is less than _collectedRewards[msg.sender], the function will always revert and users will not be able to know the reason of reverting.
Impact
Users will not be able to identify the reason of reverting of their transactions.
Tools Used
Manual Review
Recommendations
Add code in MartenitsaMarketplace::collectReward function:
- uint256 amountRewards = (count / requiredMartenitsaTokens) - _collectedRewards[msg.sender];
+ uint256 amount = (count / requiredMartenitsaTokens);
+ require( amount > _collectedRewards[msg.sender], "Cannot collect rewards!");
Updates
Lead Judging Commences
bube over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
underflow
Rewards breakdown
nSLOC
239This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.