First Flight #13: Baba Marta
First Flight #13
Beginner FriendlyFoundryGameFi
100 EXP
View results
Previous Next
Submission Details
Severity: medium
Valid

The `TranferFrom` function can be used instead of the `safeTransferFrom`one

4th05

Summary

Users can arbitrarily use the ERC721 transferFrom function instead of using the ERC721 safeTransferFrom one to transfer the MartenitsaToken with anyone else .

Vulnerability Details

ERC721 transferFrom function is not properly overwritten in the MartenitsaToken contract thus giving the possibility to the users of using it for transferring the Martenitsa token.

Impact

The difference between ERC721 transferFrom and ERC721 safeTransferFrom is the callback that ERC721 safeTransferFrom performs to ensure that the receiver is a safe recipient .

Tools Used

Manual review

Recommendations

Make these changes to the code of the MartenitsaToken contract:

+ function TransferFrom() override public {
+ revert ("Use safeTransferFrom function for the transfer.");
+ }
Updates

Lead Judging Commences

bube Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

ERC721 `transferFrom` not overriden

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.