Submission Details
Severity:
Matenitsa tokens can be sold during voting period
Summary
Winner of the voting will receive health tokens..
Vulnerability Details
voteForMartenitsa() function does not check if the NFT is listed for sale or not.
Anyone can check the NFT with highest voting and can buy it.
Impact
function testStartVotingSellDuringVotingPeriod() public listMartenitsa {
vm.warp(block.timestamp);
voting.startVoting();
assert(voting.startVoteTime() == 1);
vm.prank(bob);
voting.voteForMartenitsa(0);
vm.prank(chasy);
martenitsaEvent.approve(address(marketplace), 0);
vm.prank(bob);
marketplace.buyMartenitsa{value: 1 wei}(0);
assert(martenitsaEvent.ownerOf(0) == bob);
assert(martenitsaEvent.getCountMartenitsaTokensOwner(bob) == 1);
assert(martenitsaEvent.getCountMartenitsaTokensOwner(chasy) == 0);
assert(voting.getVoteCount(0) == 1);
}
Tools Used
foundry
Recommendations
It's recommended to add check in the function for the NFTs which are on the sale list.
Updates
Lead Judging Commences
bube about 1 year ago
Submission Judgement Published Assigned finding tags:
Unable to receive reward
Rewards breakdown
nSLOC
239This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.