Beginner FriendlyFoundryGameFi
100 EXP
View results
Submission Details
Severity: medium
Valid

Imbalance in when sending Martenitsas without updating countMartenitsaTokensOwner counter

Summary

The MartenitsaToken owner can transfer the token to anyone without updating the counter, so therefore functions that check for the counter aren't working properly.

Impact

Medium risk, as it creates an imbalance between the counter "countMartenitsaTokensOwner[]" and the amount of Martenitsas an user has. It affects other functions that use "countMartenitsaTokensOwner[]"

Tools Used

Manual Review.

Recommendations

Override functions that transfer the MartenitsaTokens (as safeTransferFrom, and , and make it update the counter prior to the transfer.

Updates

Lead Judging Commences

bube Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

ERC721 `transferFrom` not overriden

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.