Submission Details
Severity:
Inconsistency in Martenitsa tokens count when making a present to the null address
Summary
There will be an inconsistency in Martenitsa tokens count when making a present to the null address.
Vulnerability Details
In MartenitsaMarketplace.sol, a malicious actor can call makePresent() with the null address as presentReceiver:
// increments `countMartenitsaTokensOwner[address(0)]`
martenitsaToken.updateCountMartenitsaTokensOwner(presentReceiver, "add");
// decrements `countMartenitsaTokensOwner[msg.sender]`
martenitsaToken.updateCountMartenitsaTokensOwner(msg.sender, "sub");
// reverts with `ERC721InvalidReceiver(address(0))`
martertnitsaToken.safeTransferFrom(msg.sender, presentReceiver, tokenId);
Impact
Inconsistency in Martenitsa tokens count.
Tools Used
Manual review.
Recommendations
Consider adding logic to prevent making a present to the null address.
Rewards breakdown
nSLOC
239This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.