Submission Details
Severity:
Wrong logic when collecting rewards
Summary
There is wrong logic when collecting rewards.
Vulnerability Details
In MartenitsaMarketplace.sol, collectReward() does not accumulate amountRewards in _collectedRewards[msg.sender], calculating the wrongamountRewards for the user.
Impact
User can collect more Health Tokens than eligible to.
Tools Used
Manual review.
Recommendations
Change the operation :
function collectReward() external {
require(
!martenitsaToken.isProducer(msg.sender),
"You are producer and not eligible for a reward!"
);
uint256 count = martenitsaToken.getCountMartenitsaTokensOwner(
msg.sender
);
uint256 amountRewards = (count / requiredMartenitsaTokens) -
_collectedRewards[msg.sender];
if (amountRewards > 0) {
- _collectedRewards[msg.sender] = amountRewards;
+ _collectedRewards[msg.sender] += amountRewards;
healthToken.distributeHealthToken(msg.sender, amountRewards);
}
}
Rewards breakdown
nSLOC
239This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.