Beginner FriendlyFoundryGameFi
100 EXP
View results
Submission Details
Severity: high
Valid

No way to withdraw funds from `MartenitsaMarketplace`

Summary

Funds can be locked forever in the MartenitsaMarketplace contract, because there is no withdraw function.

Vulnerability Details

The buyMartenitsa::MartenitsaMarketplace.sol function, allows users to buy MT by sending eth to the contract. If a user sends more eth than the listed price of MT, the seller will receive the amount they listed their MT for and excess amount will be locked forever in the contract due to the absence of a withdraw function.

Impact

No way to withdraw funds from the contract, which means some eth can be locked inside forever.

Tools Used

Manual Review

Recommendations

Add a withdraw function, that the owner of the contract could use to retrieve the extra funds.

Updates

Lead Judging Commences

bube Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Excess ETH not refunded to the user

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.