Submission Details
Severity:
Move the if block which checks for invalid fee and invalid merkel proofs to a modifier, for cleaner code and better readability
Description
In the MerkleAirdrop.sol::claim, the "if" blocks make the code cluttered and hard to read
function claim(address account, uint256 amount, bytes32[] calldata merkleProof) external payable {
if (msg.value != FEE) {
revert MerkleAirdrop__InvalidFeeAmount();
}
bytes32 leaf = keccak256(bytes.concat(keccak256(abi.encode(account, amount))));
if (!MerkleProof.verify(merkleProof, i_merkleRoot, leaf)) {
revert MerkleAirdrop__InvalidProof();
}
emit Claimed(account, amount);
i_airdropToken.safeTransfer(account, amount);
}
Impact
Decreased readability and not a best practice
Recommended mitigation
In the MerkleAirdrop.sol::claim, the "if" blocks which check for invalid fee and invalid merkel proofs can be moved to modifiers, like so:
+ modifier validFee() {
+ require(msg.value == FEE, "MerkleAirdrop__InvalidFeeAmount");
+ _;
+ }
+ modifier validMerkleProof(address account, uint256 amount, bytes32[] calldata merkleProof) {
+ bytes32 leaf = keccak256(abi.encode(account, amount));
+ require(MerkleProof.verify(merkleProof, i_merkleRoot, leaf), "MerkleAirdrop__InvalidProof");
+ _;
+ }
+ function claim(address account, uint256 amount, bytes32[] calldata merkleProof) external payable validFee validMerkleProof(account, amount, merkleProof) {
- function claim(address account, uint256 amount, bytes32[] calldata merkleProof) external payable {
- if (msg.value != FEE) {
- revert MerkleAirdrop__InvalidFeeAmount();
- }
- bytes32 leaf = keccak256(bytes.concat(keccak256(abi.encode(account, amount))));
- if (!MerkleProof.verify(merkleProof, i_merkleRoot, leaf)) {
- revert MerkleAirdrop__InvalidProof();
- }
emit Claimed(account, amount);
i_airdropToken.safeTransfer(account, amount);
}
Rewards breakdown
nSLOC
62This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.