Submission Details
Severity:
`onlyOwner`-Gated Functions Guaranteed to Revert When Called by Normal Users Can Be Marked as `payable`
Summary
Functions using the onlyOwner modifier can be marked as payable to lower the gas cost for legitimiate callers.
Vulnerability Details
Functions using the onlyOwner modifier, such as MerkleAirdrop::claimFees, can be marked as payable to lower the gas cost for legitimiate callers by 90 gas units.
Impact
By not marking the function as payable, callers will endure a higher gas cost when calling the function.
Tools Used
Manual Analysis
Recommendations
Mark the MerkleAirdrop::claimFees function as payable.
- function claimFees() external onlyOwner {
+ function claimFees() external payable onlyOwner {
(bool succ,) = payable(owner()).call{ value: address(this).balance }("");
if (!succ) {
revert MerkleAirdrop__TransferFailed();
}
}
Rewards breakdown
nSLOC
62This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.