Beginner FriendlyDeFiFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

Pull Over Push for Token Transfers

Summary

In the claim function, the contract sends tokens directly to the claimant. While this is generally secure due to the use of SafeERC20, the pull-over-push strategy can further reduce risks associated with sending tokens and offer users more control.

Recommendations

Instead of transferring tokens directly, record claimable amounts in a mapping and let users withdraw their tokens. This approach also reduces the contract's complexity around transferring tokens and catching transfer failures.

Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.