Submission Details
Severity:
`UnripeFacet.addMigratedUnderlying()` wouldn't work with FOT tokens.
Summary
UnripeFacet.addMigratedUnderlying() wouldn't work with FOT tokens.
Vulnerability Details
addMigratedUnderlying() increases the underlying by amount after the transfer and the underlying tracking might be broken if unripeToken is a FOT token.
function addMigratedUnderlying(
address unripeToken,
uint256 amount
) external payable nonReentrant {
LibDiamond.enforceIsContractOwner();
IERC20(s.u[unripeToken].underlyingToken).safeTransferFrom(
msg.sender,
address(this),
amount
);
LibUnripe.incrementUnderlying(unripeToken, amount);
}
Impact
UnripeFacet would be broken with FOT unripeToken.
Tools Used
Manual Review
Recommendations
Underlying balances should be tracked using pre/post balances.
Updates
Lead Judging Commences
giovannidisiena over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Fee-on-transfer/rebase tokens
Prize pool breakdown
Total prize
35,000 USDC
nSLOC
1,99118 USDC / LOC
30,000 USDC
1,500 USDC
3,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.