DeFiHardhat
35,000 USDC
View results
Submission Details
Severity: low
Invalid

Library function isn't `internal` or `private`

Summary

In a library, using an external or public visibility means that we won't be going through the library with a DELEGATECALL but with a CALL. This changes the context and should be done carefully.

Instances

-LibConvert::convert
-LibWellMinting::capture

Tools Used

Manual Review

Recommendations

Change access modifier from external to internal or private.

Updates

Lead Judging Commences

giovannidisiena Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational/Invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.