Incorrect USD Price Calculation Due to 1e24 Division (Precision Issue)
Summary
The getUsdPrice() function divides 1e24 by the ETH or WSTETH price, likely in an attempt to convert the price to USD. However, this division by 1e24 might result in incorrect USD prices due to precision issues.
Impact
The division by 1e24 introduces a large scale factor that may cause the resulting USD price to be inaccurate. This can lead to incorrect calculations and potentially affect various functionalities dependent on accurate price information.
Tools Used
Manual Review
Recommendations
Review the intended behavior of the getUsdPrice() function and ensure that the division by 1e24 is appropriate for converting the ETH or WSTETH price to USD. Consider using a different scale factor or approach to avoid precision issues and ensure accurate USD price calculations.
Lead Judging Commences
Precision loss
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.