No check to ensure operations like Converting, chopping or purchasing Fertilizer are disabled during migration.
Summary
It is just mentioned that functions like converting,chopping or purchasing fertilizer will be disabled until migration is complete but no check to ensure that.
Vulnerability Details
Inside FertilizerFacet.sol, In function beginBarnRaiseMigration
In the comment it is mentioned that
* Converting, chopping and purchasing Fertilizer will be disabled until the migration is complete.
but there is no check in the function to ensure that these operations are disabled before beginning of the migration and also there is no call to UnripeFacet.addMigratedUnderlying to complete the migration process and need to call manually in the end by the LibDiamond contract or its owner.
Impact
functions like Converting, chopping or purchasing Fertilizer may still be enable at the time of migration and also UnripeFacet.addMigratedUnderlying will be called separately to complete the migration process.
Tools Used
Manual
Recommendations
Locks can be used to ensure Converting, chopping and purchasing Fertilizer is disabled during the migration process
Lead Judging Commences
Informational/Invalid
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.