Beanstalk Part 2

Summary

FertilizerFacet::totalUnfertilizedBeans returns the difference s.unfertilizedIndex - s.fertilizedIndex instead of s.unfertilizedIndex.

Vulnerability Details

While the intentions behind the implementation are not 100% clear due to missing NatSpec, the implementation of FertilizerFacet::totalFertilizedBeans suggests that FertilizerFacet::totalUnfertilizedBeans should follow the same pattern. In other words, since FertilizerFacet::totalFertilizedBeans returns s.fertilizedIndex, FertilizerFacet::totalUnfertilizedBeans should return s.unfertilizedIndex. However, the actual implementation returns the difference s.unfertilizedIndex - s.fertilizedIndex instead.

Impact

The FertilizerFacet::totalUnfertilizedBeans view function returns an unexpected value.

Tools Used

Manual review.

Recommendations

Change FertilizerFacet::totalUnfertilizedBeans to only return s.unfertilizedIndex.