Submission Details
Severity:
Underflow might occur while calculating the `notHarvestable`
Summary
Underflow might occur while calculating the notHarvestable
Vulnerability Details
The function rewardToHarvestable() is used to distributes Beans to the Field. The next amount Pods in the Pod Line become Harvestable. The issue is when calcuting the notHarvestable, it might underflow if s.f.pods < s.f.harvestable; and return an unexpected huge value.
function rewardToHarvestable(uint256 amount)
internal
returns (uint256 newHarvestable)
{
@> uint256 notHarvestable = s.f.pods - s.f.harvestable; // Note: SafeMath is redundant here.
newHarvestable = amount.div(HARVEST_DENOMINATOR);
newHarvestable = newHarvestable > notHarvestable
? notHarvestable
: newHarvestable;
s.f.harvestable = s.f.harvestable.add(newHarvestable);
}
Impact
rewardToHarvestable will be highly inflated.
Tools Used
Manual Review
Recommendations
Make sure the s.f.pods > s.f.harvestable; is done before performing the substraction.
Prize pool breakdown
Total prize
21,000 USDC
nSLOC
1,10419 USDC / LOC
17,900 USDC
1,000 USDC
2,100 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.