Submission Details
Severity:
Custom Errors 02
Summary
The provided audit concerns optimizing gas usage by replacing a require() statement with Custom Errors.
Vulnerability Detail
The require() statements in the UnripeFacet::pick function is currently used to ensure a safe run. These checks could potentially be optimized to use a Custom Error instead.
Impact
Gas optimization is the primary impact of this change. By using Custom Errors, gas costs could potentially be reduced.
Code Snippet
function pick(
address token,
uint256 amount,
bytes32[] memory proof,
LibTransfer.To mode
) external payable nonReentrant {
bytes32 root = s.u[token].merkleRoot;
require(root != bytes32(0), "UnripeClaim: invalid token");
require(!picked(msg.sender, token), "UnripeClaim: already picked");
bytes32 leaf = keccak256(abi.encodePacked(msg.sender, amount));
require(MerkleProof.verify(proof, root, leaf), "UnripeClaim: invalid proof");
s.unripeClaimed[token][msg.sender] = true;
LibTransfer.sendToken(IERC20(token), amount, msg.sender, mode);
emit Pick(msg.sender, token, amount);
}
Tool used
Manual Review
Recommendation
The function should use Custom Errors as shown below:
function pick(
address token,
uint256 amount,
bytes32[] memory proof,
LibTransfer.To mode
) external payable nonReentrant {
bytes32 root = s.u[token].merkleRoot;
if(root == bytes32(0)) {
revert("UnripeClaim: invalid token");
}
if(picked(msg.sender, token)) {
revert("UnripeClaim: already picked");
}
bytes32 leaf = keccak256(abi.encodePacked(msg.sender, amount));
if(!MerkleProof.verify(proof, root, leaf)) {
revert("UnripeClaim: invalid proof");
}
s.unripeClaimed[token][msg.sender] = true;
LibTransfer.sendToken(IERC20(token), amount, msg.sender, mode);
emit Pick(msg.sender, token, amount);
}
Prize pool breakdown
Total prize
21,000 USDC
nSLOC
1,10419 USDC / LOC
17,900 USDC
1,000 USDC
2,100 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.