Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: medium
Valid

`MondrianWallet.sol` does not correctly implement a function to mint the NFT

Summary

MondrianWallet.sol does not correctly implement a function to mint the Mondrian painting NFT.

Vulnerability Details

Currently there is no implementation that allows a user to mint an NFT. Without implementing a mint function, nobody will be able to mint a Mondrian painting NFT.

Impact

As per the documentation, you should get a random Mondrian art painting NFT when you use the MondrianWallet. However, there is no way for this NFT to be minted in this contract.

Tools Used

--Foundry/Hardhat

Recommendations

It is reccomended to Include an implementation of a mint function so that the owner can mint an NFT.

++ uint256 private _nextTokenId;
++ function mintNFT() external onlyOwner {
++ uint256 tokenId = _nextTokenId++;
++ _safeMint(msg.sender, tokenId);
++ }
Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

The Wallet doesn't end up owning any nft

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.