First Flight #15: Mondrian Wallet

Summary

Many functions are set as public, however they are not called anywhere inside MondrianWallet contract. They can be set external instead.

Vulnerability Details

The following functions from MondrianWallet contract are set as public, but are not called anywhere in the code. They can be external:

• getEntryPoint

• getNonce

• getDeposit

• addDeposit

Impact

This restricts the functions access, giving more access control to the contract.

Tools Used

Manual review.

Recommendations

Set them external instead of public.