Submission Details
Severity:
Wrong logic leads to unfair token distribution
Summary
Wrong logic in MondrianWallet::tokenURI leads to unfair token distribution.
Vulnerability Details
Quoting sponsors:
You'll see the tokenURI function returns one of 4 random Mondrian art paintings. Each should have equal distribution and be random.
MondrianWallet::tokenURI gives 70% chance of getting ART_FOUR contradicting the earlier statement, reference.
Impact
Unfair token distribution.
Tools Used
Manual review.
Recommendations
Change the code to:
+ uint256 modNumber = tokenId % 4;
- uint256 modNumber = tokenId % 10;
Updates
Lead Judging Commences
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
NFT's should have equal distribution
Rewards breakdown
nSLOC
89This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.