Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Valid

NFT URIs points to an image and not JSON file.

Description

The current URIs point to images, not JSON metadata. This is not the standard practice, which may cause some wallets, explorers, or marketplaces to not fully recognize or display the NFTs correctly.

/*//////////////////////////////////////////////////////////////
NFT URIS
//////////////////////////////////////////////////////////////*/
string constant ART_ONE =
"ar://jMRC4pksxwYIgi6vIBsMKXh3Sq0dfFFghSEqrchd_nQ";
string constant ART_TWO =
"ar://8NI8_fZSi2JyiqSTkIBDVWRGmHCwqHT0qn4QwF9hnPU";
string constant ART_THREE =
"ar://AVwp_mWsxZO7yZ6Sf3nrsoJhVnJppN02-cbXbFpdOME";
string constant ART_FOUR =
"ar://n17SzjtRkcbHWzcPnm0UU6w1Af5N1p0LAcRUMNP-LiM";

Risk

Likelyhood: High

Impact: Very Low

Proof of Concept

All these links only display images:
https://arweave.net/jMRC4pksxwYIgi6vIBsMKXh3Sq0dfFFghSEqrchd_nQ/
https://arweave.net/8NI8_fZSi2JyiqSTkIBDVWRGmHCwqHT0qn4QwF9hnPU/
https://arweave.net/AVwp_mWsxZO7yZ6Sf3nrsoJhVnJppN02-cbXbFpdOME/
https://arweave.net/n17SzjtRkcbHWzcPnm0UU6w1Af5N1p0LAcRUMNP-LiM/

Here is an URI with a valid JSON file: https://arweave.net/eXcwlbsV1BiRGCsGKXa60Mj0i-xDZU0k95l_ysNwv_w/

Recommended Mitigation

Create JSON files containing metadata and replace the current links with URIs pointing to these JSON files.

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

NFT URI is an image not a JSON as it should be

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.