First Flight #15: Mondrian Wallet
First Flight #15
Beginner FriendlyFoundry
100 EXP
View results
Previous Next
Submission Details
Severity: high
Invalid

`MondrianWallet::validateUserOp` does not return a value as required by the Interface resulting in an unknown status of the UserOperation

poolig4n

Description

The function MondrianWallet::validateUserOp should return a value but does not return a value. This is contradictory to the NatSpec and to the Interface leading to incorrect validation of the UserOperations.

function validateUserOp(
PackedUserOperation calldata userOp,
bytes32 userOpHash,
uint256 missingAccountFunds
) external returns (uint256 validationData);

Impact

As validation data is not returned the caller will not be able to determine the validity of the UserOperation. This will either lead to failures or processing invalid UserOperations depending upon how the caller handles the lack of result.

Recommended mitigation

  • The function should return the correct validationData object as per the documentation.

Tools:

  • Manual Review

Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.