Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

recommendation: use the signature aggregator

Summary

Mondrian Wallet recommends users create accounts mean addresses, and utilize UserOperations (UserOps) within the ERC-4337 framework. UserOps allows delegating transaction initiation to third-party addresses, but security measures are crucial to prevent unauthorized access.

The provided code snippet reveals a potential security concern due to the absence of an explicit "signature aggregator contract" in the _validateSignature function.

Vulnerability Details

The _validateSignature function focuses solely on verifying the cryptographic signature on a UserOp.
It doesn't inherently check if the signing address is authorized to create UserOps for the wallet.
Without an aggregator contract or a separate authorization check within the EntryPoint contract, there's a risk of unauthorized transactions

Impact

Unauthorized transactions could drain funds from the Mondrian wallet.
Loss of control over the wallet's assets

Tools Used

manual review, foundry test

Recommendations

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

ECDSA.recover should check against sender

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.