Sablier

Sablier
DeFiFoundry
53,440 USDC
View results
Submission Details
Severity: low
Invalid

Natspec for Lockup library incomplete

Summary

The Lockup library is imported into LockupLinear, LockupDynamic, and LockupTranched. However the Natspec comments for the library only mention that it is used in SablierV2LockupLinear and SablierV2LockupDynamic.

Vulnerability Details

The libraries imported into the LockupTranched file are not consistently documented in DataTypes.sol.

Impact

Informational. With the addition of tranched streams to Sablier, it is best to update and complete the DataTypes documentation.

Tools Used

Manual review

Recommendations

Add {SablierV2LockupTranched} to the @notice comment above the Lockup library.

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Info/Gas/Invalid as per Docs

https://docs.codehawks.com/hawks-auditors/how-to-determine-a-finding-validity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.