Sablier

Sablier
DeFiFoundry
53,440 USDC
View results
Submission Details
Severity: low
Invalid

redundant check in the withdraw function

Summary

redundant check in the withdraw function

Vulnerability Details

the if statement check if the to address isn't the recipient, but the _isCallerStreamRecipientOrApproved() allready check for that.
https://github.com/Cyfrin/2024-05-Sablier/blob/449257087fead2877a72fed5ce042549d81bd5a2/v2-core/src/abstracts/SablierV2Lockup.sol#L468C1-L472C6

Recommendations

remove the first check.

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Info/Gas/Invalid as per Docs

https://docs.codehawks.com/hawks-auditors/how-to-determine-a-finding-validity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.