Submission Details
Severity:
`public` functions not used internally could be marked `external`
Description: Instead of marking a function as public, consider marking it as external if it is not used internally.
Recommended Mitigation
Found in src/abstracts/Adminable.sol [Line: 35]
/// @inheritdoc IAdminable
+ function transferAdmin(address newAdmin) public virtual override onlyAdmin {
// Effect: update the admin.
admin = newAdmin;
// Log the transfer of the admin.
emit IAdminable.TransferAdmin({ oldAdmin: msg.sender, newAdmin: newAdmin });
}
Found in src/abstracts/SablierV2Lockup.sol [Line: 193]
+ function statusOf(uint256 streamId) external view override notNull(streamId) returns (Lockup.Status status) {
Found in src/abstracts/SablierV2Lockup.sol [Line: 199]
+ function streamedAmountOf(uint256 streamId)
public
view
override
notNull(streamId)
returns (uint128 streamedAmount)
{
streamedAmount = _streamedAmountOf(streamId);
}
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Info/Gas/Invalid as per Docs
https://docs.codehawks.com/hawks-auditors/how-to-determine-a-finding-validity
Prize pool breakdown
Total prize
53,440 USDC
nSLOC
2,65520 USDC / LOC
45,000 USDC
3,100 USDC
5,340 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.