Sablier

Sablier
DeFiFoundry
53,440 USDC
View results
Submission Details
Severity: low
Invalid

Unused public functions could be made external

Summary

L-3: public functions not used internally could be marked external

Vulnerability Details

  • Found in src/abstracts/Adminable.sol Line: 34

    function transferAdmin(address newAdmin) public virtual override onlyAdmin {
  • Found in src/abstracts/SablierV2Lockup.sol Line: 198

    function streamedAmountOf(uint256 streamId)
  • Found in src/abstracts/SablierV2Lockup.sol Line: 209

    function tokenURI(uint256 streamId) public view override(IERC721Metadata, ERC721) returns (string memory uri) {

Impact

Low

Tools Used

Aderyn

Recommendations

Instead of marking a function as public, consider marking it as external if it is not used internally.

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Info/Gas/Invalid as per Docs

https://docs.codehawks.com/hawks-auditors/how-to-determine-a-finding-validity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.