Submission Details
Severity:
`helpers#calculateSegmentTimestamps` can directly return when `segmentCount` is 0 or 1
Summary
helpers#calculateSegmentTimestamps can directly return when segmentCount is 0 or 1
Vulnerability Details
Function helpers#calculateSegmentTimestamps:
function calculateSegmentTimestamps(LockupDynamic.SegmentWithDuration[] memory segments) {
uint256 segmentCount = segments.length;
segmentsWithTimestamps = new LockupDynamic.Segment[](segmentCount);
...
segmentsWithTimestamps[0] = LockupDynamic.Segment({
amount: segments[0].amount,
exponent: segments[0].exponent,
timestamp: startTime + segments[0].duration
});
// Copy the segment amounts and exponents, and calculate the segment timestamps.
for (uint256 i = 1; i < segmentCount; ++i) {
segmentsWithTimestamps[i] = LockupDynamic.Segment({
amount: segments[i].amount,
exponent: segments[i].exponent,
timestamp: segmentsWithTimestamps[i - 1].timestamp + segments[i].duration
});
}
...
}
When segmentCount is 0 or 1, the function can directly return instead of subsequently calling the for loop.
Impact
Cost more gas.
Tools Used
vscode, Manual Review
Recommendations
The function can directly return when segmentCount is 0 or 1.
Prize pool breakdown
Total prize
53,440 USDC
nSLOC
2,65520 USDC / LOC
45,000 USDC
3,100 USDC
5,340 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.