Submission Details
Severity:
importing the SablierV2Lockup twice in SablierV2LockupLinear.sol
Summary
In the v2-core/src/SablierV2LockupLinear.sol file, SablierV2Lockup is imported twice.
Vulnerability Details
As said in the summary, the SablierV2Lockup is imported twice.
https://github.com/Cyfrin/2024-05-Sablier/blob/43d7e752a68bba2a1d73d3d6466c3059079ed0c6/v2-core/src/SablierV2LockupLinear.sol#L9C1-L10C67
import { SablierV2Lockup } from "./abstracts/SablierV2Lockup.sol";
import { SablierV2Lockup } from "./abstracts/SablierV2Lockup.sol";
Impact
It is useless and misleading to import the same import in the same contract twice.
Tools Used
Manual Review
Recommendations
Remove one of the duplicated imports:
import { SablierV2Lockup } from "./abstracts/SablierV2Lockup.sol";
- import { SablierV2Lockup } from "./abstracts/SablierV2Lockup.sol";
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Info/Gas/Invalid as per Docs
https://docs.codehawks.com/hawks-auditors/how-to-determine-a-finding-validity
Prize pool breakdown
Total prize
53,440 USDC
nSLOC
2,65520 USDC / LOC
45,000 USDC
3,100 USDC
5,340 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.