Sablier

Sablier
DeFiFoundry
53,440 USDC
View results
Submission Details
Severity: low
Invalid

`ASSET.forceApprove` in `SablierV2MerkleLL.sol::constructor` will not work if `ASSET` is a token, that doesn't support approve `type(uint256).max` amount.

Vulnerability Details

The SablierV2MerkleLL.sol allow users to claim Airdrops using Merkle proofs. These airdrops are powered by Lockup Linear streams. In the SablierV2MerkleLL.sol::constructor we max approve the Sablier contract. However, some tokens like UNI do not support the approving the spender type(uint256).max amount of tokens. In this way ASSET.forceApprove will not work for such tokens.

Impact

Tokens that don't support approve type(uint256).max amount could not be used in the SablierV2MerkleLL.sol contract.

Tools Used

Manual Review

Recommendations

Consider using a different approach to approve the spender for tokens that don't support approve type(uint256).max amount or make the contract logic to not work with such tokens.

Updates

Lead Judging Commences

inallhonesty Lead Judge
about 1 year ago
inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement
Assigned finding tags:

ERC20 UNI and COMP Revert on Large Approvals

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.