Sablier

Sablier
DeFiFoundry
53,440 USDC
View results
Submission Details
Severity: low
Invalid

MAX_SEGMENT_COUNT value is not checked.

Summary

MAX_SEGMENT_COUNT value is not checked.

Vulnerability Details

in docs it says:
"There is a limit to how many segments there can be in a stream, and that is 300 segments. This requirement is due to the block gas limit.
If it didn't exist and someone created a stream with an excessively large number of segments, the transaction would revert as it wouldn't fit within a block"

but in SablierV2LockupDynamic.sol there is no check that MAX_SEGMENT_COUNT is less than 300.

Impact

The transaction would revert as it wouldn't fit within a block as it is mentioned in docs.

Tools Used

Manual

Recommendations

check that maxSegmentCount is <= 300.

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement
0xgenaudits Submitter
about 1 year ago
inallhonesty Lead Judge
about 1 year ago
0xgenaudits Submitter
about 1 year ago
inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.