Sablier

Sablier
DeFiFoundry
53,440 USDC
View results
Submission Details
Severity: low
Invalid

Admin Transfer in Single step

Summary

In Adminable.sol The transferAdmin function is used to set a new admin address. It accepts an address of new admin and sets it to the admin variable. However making such an important change in a single step can be error-prone such as the new admin could be set to an incorrect or an unintended address which cannot be changed or if the new admin loses access to their address they cannot perform admin actions

Vulnerability Details

see summary

Impact

If the admin address is incorrectly set to an unintended address that address would have unintended access to admin privileges/functions or the admin could lose the admin privileges if they lose access to their address

Tools Used

Manual Review

Recommendations

Implement a two-step admin transfer process, wherein the current admin first proposes a new admin and the new admin then accepts it.

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Info/Gas/Invalid as per Docs

https://docs.codehawks.com/hawks-auditors/how-to-determine-a-finding-validity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.