Submission Details
Severity:
Single step ownership transfer.
Summary
TransferAdmin() function of Adminable.sol uses single step ownership transfer which is not optimal.
Vulnerability Details
Here is the implementation of TransferAdmin() function:
function transferAdmin(address newAdmin) public virtual override onlyAdmin {
// Effect: update the admin.
admin = newAdmin;
// Log the transfer of the admin.
emit IAdminable.TransferAdmin({ oldAdmin: msg.sender, newAdmin: newAdmin });
}
This function directly sets admin to newAdmin. This is a very risky approach as admin can set incorrect address or the address set can be zero address.
Impact
All the onlyAdmin() function can be locked.
Tools Used
Manual Analysis
Recommendations
Implement a two step mechanism in which newOwner accepts the ownership with acceptOwnership() function.
Updates
Lead Judging Commences
inallhonesty about 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Info/Gas/Invalid as per Docs
https://docs.codehawks.com/hawks-auditors/how-to-determine-a-finding-validity
Prize pool breakdown
Total prize
53,440 USDC
nSLOC
2,65520 USDC / LOC
45,000 USDC
3,100 USDC
5,340 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.