Sablier

Summary

The admin address is set as sender when merklell and merkleLTs are created. In case of an admin change, the sender functions will no longer be available to the current admin, while being available to the previous admin. If the admin was changed

Vulnerability Details

When the merkles are created, the admin is set as sender both for the MerkleLL and MerkleLTs.

The issue is that the admin can be changed, but this change is not reflected in the previously created merkles, as senders.

If the previous admin had to transfer ownership to protect the protocol from potential attackers (a last ditch method for instance), the merkles that the previous admin had created would still remain under his control and while the new admin has no access to it. The new admin for instance, cannot cancel or renounce the merkle streams.

Impact

New admin has no access to previously created merkles, while the previous admin does.

Tools Used

Manual review

Recommendations

Consider introducing an admin function to change senders, which can be called before ownership transfer.