Sablier

Sablier
DeFiFoundry
53,440 USDC
View results
Submission Details
Severity: low
Valid

ERC standard not followed

Summary

The SablierV2Lockup contract implements ERC4906 standard. This standard is EIP721 extension and it adds events when token's metadata is updated.

Vulnerability Details

As can be seen here, the standard states that:

The supportsInterface method MUST return true when called with 0x49064906.

This can not be seen in the smart contract, which does not comply with ERC4906.

Impact

Contract not complies with inherited standard.

Tools Used

Manual Review

Recommendations

Add supportsInterface method that will return true when called with 0x49064906.

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Info/Gas/Invalid as per Docs

https://docs.codehawks.com/hawks-auditors/how-to-determine-a-finding-validity

0xnevi Judge
about 1 year ago
inallhonesty Lead Judge
about 1 year ago
inallhonesty Lead Judge 12 months ago
Submission Judgement Published
Validated
Assigned finding tags:

supportsInterface() not properly implemented to support ERC4906

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.